Skip to content

Conversation

@durran
Copy link
Member

@durran durran commented Nov 2, 2023

Description

Updates the load balancer test docs with alternative setup.

What is changing?

Docs update.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title docs: update load balancer docs docs(NODE-5730): update load balancer docs Nov 6, 2023
Copy link
Contributor

@aditi-khare-mongoDB aditi-khare-mongoDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit but is there a reason why the last checkbox of the self-review isn't checked off?

@durran
Copy link
Member Author

durran commented Nov 7, 2023

LGTM, nit but is there a reason why the last checkbox of the self-review isn't checked off?

I didn't check it as there were no TODOs added in this PR.

@durran durran added the Team Review Needs review from team label Nov 7, 2023
@durran durran merged commit c0506b1 into main Nov 8, 2023
@durran durran deleted the lb-docs branch November 8, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants